chore: remove TerserPlugin step for build #16163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16163 +/- ##
=======================================
Coverage 76.81% 76.81%
=======================================
Files 996 996
Lines 52942 52942
Branches 6734 6734
=======================================
Hits 40668 40668
Misses 12049 12049
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
zhaoyongjie
approved these changes
Aug 10, 2021
There was a problem hiding this comment.
https://webpack.js.org/plugins/terser-webpack-plugin/
Webpack v5 or above don't need to installTerserPlugin
LGTM
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Trying webpack without
TerserPlugin, there doesn't seem to be any impact on the bundle size, yet we save a bunch of cpu time on thenpm run buildstep. To be fair, when I don't remove the.terser-plugin-cache/, the difference is minimal, but assuming docker isn't doing anything special to keep that cache active, in that context, or in the context of a new env, the hit is pretty significant. This only affectnpm run buildbut could shave a few minutes from some of our builds.Methodology
With Terser
Without Terser